-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column-based filters for mutation tables #3831
Add column-based filters for mutation tables #3831
Conversation
21d6153
to
ccace2e
Compare
5dca22a
to
60e8b21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for changing the design to use DataFilters
! Added some suggestions to further improve the clarity of the filters.
src/shared/components/mutationTable/column/CosmicColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
src/shared/components/mutationTable/column/FunctionalImpactColumnFormatter.tsx
Outdated
Show resolved
Hide resolved
c32c454
to
b091486
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
d3c3f2e
to
3f30f3c
Compare
Great job! Thanks, @Rajat-Sirohi @Rajat-Sirohi @Luke-Sikina can we add one additional feature either part of this or or a separate one? It would be really useful to add a link to the study view for the filtered samples. |
Issue with Exon column in this query |
Thanks for identifying that bug, @jjgao ! It was a problem with computing the min/max for the column, where the Exon column was returning a fraction, not a valid number. I've now fixed it and will update the code in the next push. |
add3ef6
to
dcf543e
Compare
dcf543e
to
63dc44a
Compare
71fc949
to
32aa703
Compare
@Rajat-Sirohi i noticed one tiny bug where the filter icon won't show up. If I go here, mouse over the protein change column header, click on the fliter icon and search for 1000, then click anywhere on the page. The blue filter icon doesn't show up: Once I mouse over again, it does show up. Doesn't really have to be a blocker for merging tho, but curious if there's an easy solution One separate other tiny thing is that the filtering icon shows up even if you are quite far away from the column. Could be considered a feature but to me it seems more clear to only show the icon when you mouseover the column header: |
@inodb The first issue happens because the input box is over a different column, so the filter icon isn't shown until that column is moused over again. I'll definitely see what I can do, but I don't think there's an easy fix. To your second point, I just check the horizontal coordinates of the cursor and see if it's inside a column, and if so then I show the filter icon. I don't check vertical coordinates because I was told to show it if the mouse is inside any part of the column, not just the header. Unfortunately I also end up showing it if the mouse is above the column due to an issue where the vertical position of the column header sometimes changes. I don't think there's an easy fix for that either. |
32aa703
to
0a333ab
Compare
@inodb I've now fixed that first issue so that the filter icon is visible so long as the cursor is either over the column OR the filter menu is open. Thanks for pointing it out. I think I will leave the other part as is, where the icon is shown regardless of the vertical position of the cursor. This might seem unnecessary, especially when the cursor is above the column header, but I think it's better to ensure that the user knows that filtering is an option rather than risk them not even noticing the icon if were to make its visibility so restrictive, e.g., if it were only shown when hovering over the column header. |
… time instead of pars
0a333ab
to
a7da984
Compare
a7da984
to
f18c1c6
Compare
Fix cBioPortal/cbioportal#8713 and
2.2 Filtering per column
in cBioPortal/cbioportal#8711Changes:
NumericalFilter
andCategoricalFilter
, which are attached to columns in the results view mutation table