Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save Column Visibility & Add "Reset Columns" Button #8521

Closed
2 tasks
inodb opened this issue Apr 15, 2021 · 1 comment · Fixed by cBioPortal/cbioportal-frontend#3846
Closed
2 tasks

Save Column Visibility & Add "Reset Columns" Button #8521

inodb opened this issue Apr 15, 2021 · 1 comment · Fixed by cBioPortal/cbioportal-frontend#3846
Assignees
@Rajat-Sirohi
Labels
discussion enhancement good first issue

Comments

@inodb
Copy link
Member

inodb commented Apr 15, 2021 •
edited
Loading

We want to be able to store the columns that a user selected (e.g. chrom/pos/ref/alt).

  • store current column selection in localStorage (so when switching genes on mutations tab it will keep the same state)
  • maybe have some way to indicate that you want to persist the current column selection (instead of always saving). Those setting can then be saved in session service

Discussion points:

  • Alternatively we always save in session service to avoid having to build the UI for that
  • store patient view table and mutations tab user settings separately?

The more long term goal with this is to be able to also store specific annotations that have been selected.
@inodb inodb mentioned this issue Apr 15, 2021
Closed
@jjgao
Copy link
Member

jjgao commented Apr 23, 2021

I think it makes sense to have separate settings for the mutations tab and patient view.

Saving to localstorage seems like an easy option to go... It doesn't seem to be a critical setting that would warranty saving to the user profile or session/url...

@leexgh leexgh mentioned this issue Jun 22, 2021
Open
13 tasks
@Rajat-Sirohi Rajat-Sirohi mentioned this issue Jul 16, 2021
Merged
@Rajat-Sirohi Rajat-Sirohi changed the title Store user settings on what columns are shown for patient view and mutations tab separately Save Column Visibility & Add "Reset Columns" Button Jul 20, 2021
inodb pushed a commit to cBioPortal/cbioportal-frontend that referenced this issue Jul 23, 2021
@Rajat-Sirohi
Save Column Visibility & Add "Reset Columns" Button (#3846)
3a990bc 
Fixes cBioPortal/cbioportal#8521, 3.1 Store user settings and 3.2 Add "reset to default" button based on app configuration in cBioPortal/cbioportal#8711, points 3 & 4 in cBioPortal/cbioportal#8716.

Changes:

Remembers active column selection when switching genes in Results View Mutation Table
Adds "Reset Columns" button which resets the visible columns back to their initial configuration (i.e., according to the visible attribute in the column definition). Note, this button is only shown when the current column selection is different from the default configuration. (Feedback on its design is appreciated.)
Fixes bug in cbioportal-frontend-commons where user-selection was prevented when passing columnVisibility prop to LazyMobXTable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rajat-Sirohi Rajat-Sirohi

Labels
discussion enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Save Column Visibility & Add "Reset Columns" Button Rajat-Sirohi/cbioportal-frontend
3 participants
@jjgao @inodb @Rajat-Sirohi