Add support for using Sushi models with the exists validation rule
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! This is great! |
|
@calebporzio - this looks super useful, any chance you can cut a tagged release for this? |
calebporzio
pushed a commit
that referenced
this pull request
Aug 11, 2021
After introducing sushi to our project, our monitoring tool reported the following error (stacktrace shortened for brevity): ``` PDOException: SQLSTATE[HY000]: General error: 1 table "schmelzkurve_scoring_table_results" already exists #88 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(485): PDOStatement::execute #87 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(485): Illuminate\Database\Connection::Illuminate\Database\{closure} #86 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(685): Illuminate\Database\Connection::runQueryCallback #85 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(652): Illuminate\Database\Connection::run #84 /vendor/laravel/framework/src/Illuminate/Database/Connection.php(486): Illuminate\Database\Connection::statement #83 /vendor/laravel/framework/src/Illuminate/Database/Schema/Blueprint.php(109): Illuminate\Database\Schema\Blueprint::build #82 /vendor/laravel/framework/src/Illuminate/Database/Schema/Builder.php(365): Illuminate\Database\Schema\Builder::build #81 /vendor/laravel/framework/src/Illuminate/Database/Schema/Builder.php(228): Illuminate\Database\Schema\Builder::create #80 /vendor/calebporzio/sushi/src/Sushi.php(142): App\Models\SchmelzkurveScoringTableResult::createTable #79 /vendor/calebporzio/sushi/src/Sushi.php(89): App\Models\SchmelzkurveScoringTableResult::migrate #78 /vendor/calebporzio/sushi/src/Sushi.php(45): App\Models\SchmelzkurveScoringTableResult::Sushi\{closure} #77 /vendor/calebporzio/sushi/src/Sushi.php(66): App\Models\SchmelzkurveScoringTableResult::bootSushi ``` This error can happen in rare circumstances due to a race condition. Concurrent requests may both see the necessary preconditions for the table creation, but only one can actually succeed. My initial attempt at resolving this was to look for a method that creates the table only if it does not exist (`create table if not exists`), but Laravel exposes no such method. Thus, I think the only viable solution is to risk it and catch the resulting error.
|
Hi @mallardduck & @bakerkretzmar - I'm going to tag this release right now, can one of you document this addition in the README file? |
|
@calebporzio - sure thing. i'll whip up a PR real quick |
|
Thanks! |
|
Just tagged 2.3.0 |
|
There's actually a major issue with this - it only works if you have one Sushi model 😆 Spent a few hours bashing my head on the table about it this morning. Will submit another PR. |
|
Pushed a fix for the multiple model issue in #96. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Sushi's generated database connection to the app config
database.connectionsarray, which makes it possible to use Sushi models with theexistsdatabase rule. Accomplishes the same thing as #80 but using Laravel's existing validation infrastructure.