Cannot use exists validation without manually specifying connection name & fix multiple model support

[danharrin]

At the moment, the connection name needs manually specifying when using the exists rule.

Rule::exists('sushi.Model');

This kinda defeats the object of passing the class as the table name, as it should resolve the connection automatically 😆

Thankfully, you just need to override the getConnectionName() method on the model.

Now, you can use:

Rule::exists('Model');

// or

Rule::exists(Model::class);

[mallardduck]

Great catch, looks good.

[danharrin]

As per #88 - I've found a major issue with the approach made in that PR - only one Sushi model is supported at a time.

I've updated this PR to include the fix for this feature to work with multiple models.

[calebporzio]

Thanks @danharrin

[huyby]

Edit: there's already a PR for this #98

This PR breaks Eloquent relationships defined in a Sushi model.

When Eloquent resolves a relationship, the related model will use the connection from the parent model, unless a connection name is defined explicitly in the related model itself. See Illuminate\Database\Eloquent\Concerns::newRelatedInstance()

As the parent model now returns the parent model class name as a connection name, the related model will also use this value and will not use the application's default connection.

namespace App\Models;

use Illuminate\Database\Eloquent\Model;


class Role extends Model
{
    use Sushi\Sushi;

   protected $rows = [
        [
            'id'          => 1,
            'name'    => 'admin',
        ],
   ];

    public function users()
    {
        return $this->hasMany(User::class);
    }
}

class User extends Model
{
}

Role::find(1)->users will fail as it will use Sushi's sqlite connection to execute the relationship query, instead of the applications default database connection.

I'll try to make a PR to resolve the issue, a bit short on time like everyone else 🙈

If anyone struggles with this, a quick fix is to define a connection name on the related model; or return the default application database connection name.

class User extends Model
{
    public function getConnectionName()
    {
        return config('database.default');
    }
}