Use Typescript for package sources implementation #424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BartoszKlonowski
requested review from
deorst,
michalchudziak,
okwasniewski and
thymikee
thymikee
reviewed
Sep 5, 2022
okwasniewski
reviewed
Sep 8, 2022
okwasniewski
approved these changes
Sep 9, 2022
michalchudziak
requested changes
Sep 13, 2022
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
BartoszKlonowski
force-pushed
the
chore/use-typescript-for-package-implementation
branch
from
addb081 to
c8475ad
Compare
michalchudziak
approved these changes
Sep 14, 2022
thymikee
deleted the
chore/use-typescript-for-package-implementation
branch
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces Typescript to the package implementation, instead of Flow.
This is done to package/ only, while example app is to be done for another PR - along with the example app update to v0.70 of react-native.
This implementation is part of #396
This PR updates also the CI to include the typechecking and modifies the sources compilation with Babel.