Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a348214
Install Typescript and babel plugin
BartoszKlonowski Aug 23, 2022
a3a87a2
Rename all source files to ts
BartoszKlonowski Aug 23, 2022
675ff04
Use TSX for Slider component
BartoszKlonowski Aug 23, 2022
56fa615
Configure TS for package compilation with Babel
BartoszKlonowski Aug 23, 2022
710d524
Fix syntax and typechecking for mobile sources
BartoszKlonowski Aug 23, 2022
2198fde
Use native event instead of synthetic event
BartoszKlonowski Aug 24, 2022
9081fb5
Add docs for tapToSeek property
BartoszKlonowski Aug 24, 2022
3f048df
Update example lockfile for packages
BartoszKlonowski Aug 24, 2022
e5d85e2
Convert web module into JSX file and translate into TS
BartoszKlonowski Aug 25, 2022
25d5eb3
Include typechecking during CI workflow
BartoszKlonowski Aug 25, 2022
40fc658
Update snapshots regarding new TS files
BartoszKlonowski Aug 25, 2022
484d66f
Update tests to use TS with JSX syntax
BartoszKlonowski Sep 1, 2022
23a5094
Update sources to new prettier parsing option
BartoszKlonowski Sep 1, 2022
d8f3b75
Use interface for NativeProps instead of type
BartoszKlonowski Sep 2, 2022
3ba2bc1
Use ImageSource as a type for image instead of URI based
BartoszKlonowski Sep 2, 2022
ffd3253
Use JSON for Babel config instead of JS
BartoszKlonowski Sep 2, 2022
6a5b65f
Rename TypeScript check to avoid copy-paste error
BartoszKlonowski Sep 5, 2022
0b89f0a
Cover review remarks
BartoszKlonowski Sep 8, 2022
194781f
Keep using bubbling events for continous change
BartoszKlonowski Sep 9, 2022
a9a66e9
Update lockfiles after recent main changes
BartoszKlonowski Sep 13, 2022
c8475ad
Fix typing for react-test-renderer by adding @types
BartoszKlonowski Sep 13, 2022
096013d
Check for Example app typechecking and fix leftover mistakes
BartoszKlonowski Sep 13, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions .github/workflows/ReactNativeSlider-CI.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
key: ${{ hashFiles('./package/package.json') }}


lint:
verify-package-sources:
name: Lint the sources
runs-on: ubuntu-latest
needs: install
Expand All @@ -39,6 +39,9 @@ jobs:
- name: Run ESLint on the sources
run: cd package && npx eslint src

- name: Run TypeScript on the sources
run: cd package && npx tsc --noEmit


test:
name: Run the unit tests
Expand All @@ -59,7 +62,7 @@ jobs:
run: cd package && npx jest src


verify:
verify-example-sources:
name: Verify example app sources
runs-on: ubuntu-latest

Expand All @@ -73,11 +76,13 @@ jobs:
- name: Run ESLint on the sources
run: cd example && npx eslint .

- name: Run TypeScript on the sources
run: cd example && npx tsc --noEmit

build-android-app:
name: Build example app Android
runs-on: ubuntu-latest
needs: [verify]
needs: [verify-example-sources]

steps:
- uses: actions/checkout@v3
Expand All @@ -97,7 +102,7 @@ jobs:
build-iOS-app:
name: Build example app iOS
runs-on: macos-latest
needs: [verify]
needs: [verify-example-sources]
steps:
- uses: actions/checkout@v3

Expand Down
2 changes: 1 addition & 1 deletion example/SliderExample.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export const examples = [
{
title: 'Vertical slider',
platform: 'windows',
render(): Element<any> {
render() {
return <SliderExample value={0.6} vertical />;
},
},
Expand Down
10 changes: 8 additions & 2 deletions example/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions example/tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
// prettier-ignore
{
"include": ["./SliderExample.tsx", "./App.tsx", "./index.tsx"],
"extends": "@tsconfig/react-native/tsconfig.json", /* Recommended React Native TSConfig base */
"compilerOptions": {
/* Visit https://aka.ms/tsconfig.json to read more about this file */
Expand Down
3 changes: 0 additions & 3 deletions package/babel.config.js

This file was deleted.

3 changes: 3 additions & 0 deletions package/babel.config.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"presets": ["@babel/preset-typescript", "module:metro-react-native-babel-preset"]
}
Loading