chore(breaking): deprecate flushMicrotasksQueue #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
May 20, 2020
src/flushMicrotasksQueue.js
Outdated
| return flushMicrotasksQueueInternal(); | ||
| } | ||
|
|
||
| export function flushMicrotasksQueueInternal(): Promise<any> { |
There was a problem hiding this comment.
Can we call it just flushMicrotasks?
There was a problem hiding this comment.
Renamed to flushMicroTasks as this is how it's spelled in RTL
thymikee
reviewed
May 20, 2020
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
thymikee
approved these changes
May 20, 2020
thymikee
changed the title
This was referenced May 20, 2020
thymikee
added a commit
that referenced
this pull request
May 28, 2020
* Deprecated flushMicrotasksQueue * Update website/docs/Migration20.md Co-authored-by: Michał Pierzchała <thymikee@gmail.com> * Renamed flushMicrotasksQueueInternal to flushMicroTasks Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Making
flushMicrotasksQueuedeprecated in favor offindByandwaitFor.Closes #339
Test plan