feature: wait for element to be removed #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdjastrzebski
commented
Jun 6, 2020
src/waitForElementToBeRemoved.js
Outdated
| export default async function waitForElementToBeRemoved<T>( | ||
| expectation: () => T, | ||
| options?: WaitForOptions | ||
| ): Promise<null> { |
There was a problem hiding this comment.
Not sure if null is a proper type here. But we do not have anything meaningful to return.
RTL declares its version in TS as Promise<T> but uses return true in their impl.
There was a problem hiding this comment.
IMO I would keep the Promise<T> return type and return the initial result of expectation call. Since in code we require that initially expectation is successful (returns something) and only then starts throwing/returning nothing.
There was a problem hiding this comment.
Also logged issue in Dom TL that they have similar discrepancy.
thymikee
force-pushed
the
feature/waitForElementToBeRemoved
branch
from
e2fb263 to
1143370
Compare
|
Used
|
thymikee
approved these changes
Jun 9, 2020
| :::info | ||
| In order to properly use `waitFor` you need at least React >=16.9.0 (featuring async `act`) or React Native >=0.60 (which comes with React >=16.9.0). | ||
| ::: | ||
|
|
||
| If you're using Jest's [Timer Mocks](https://jestjs.io/docs/en/timer-mocks#docsNav), remember not to use `async/await` syntax as it will stall your tests. |
There was a problem hiding this comment.
for later: we need to figure out why this happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
waitForElementToBeRemovedimplementation with tests & typescript types.Resolves #375
Test plan
Added tests based on
waitFor& veryfinggetBy,getAllBy,queryBy&queryAllByqueries.