fix: fire event should not throw for disabled handler #470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Jul 31, 2020
thymikee
reviewed
Jul 31, 2020
mdjastrzebski
force-pushed
the
fix/fire-event-should-not-throw-for-disabled-handler
branch
from
7f1f126 to
1eaf07e
Compare
thymikee
approved these changes
Jul 31, 2020
thymikee
deleted the
fix/fire-event-should-not-throw-for-disabled-handler
branch
This was referenced Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #469
RNTL has a check that throws error when event handler missing. This is intended to inform developer that there is a mismatch between test assertions and components under test. This PR fixes a cases when this check throws error while component has a disabled event handler.
Test plan