Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add GitHub integration #559

Merged
merged 44 commits into from
May 25, 2024
Merged

feat: Add GitHub integration #559

merged 44 commits into from
May 25, 2024

Conversation

rsrbk
Copy link
Collaborator

@rsrbk rsrbk commented May 16, 2024

Description

The issue adds capability to build an agent that can solve specific issues in GitHub repos. It works by introducing a GitHubLoader which is a wrapper on top of PyGithub to do various operations with GitHub API like retrieving open issues or creating a pull request.

The new set up functions introduced in github_functions.py allows agent to interact with GitHubLoader and perform tasks specified by humans.

Lastly, the new prompt template allows to easily construct the correct prompt that will fix a specific issue in a github repo and submits a PR with the fix.

Motivation and Context

Progressing on the CAMEL roadmap which involves building software engineering agents.

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Loader
  • Prompt template
  • Functions
  • Example
  • Unit Tests

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

Copy link

coderabbitai bot commented May 16, 2024

Important

Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Wendong-Fan
Copy link
Member

Thanks @rsrbk ! Seems we have some conflicts need to be solved, please do this when you have time

@Wendong-Fan Wendong-Fan linked an issue May 16, 2024 that may be closed by this pull request
2 tasks
@Wendong-Fan Wendong-Fan added this to the Sprint 3 milestone May 16, 2024
@Wendong-Fan Wendong-Fan requested a review from a team May 16, 2024 15:25
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rsrbk for your first contribution! It is amazing. Left some comments.

camel/functions/github_functions.py Outdated Show resolved Hide resolved
camel/functions/github_functions.py Outdated Show resolved Hide resolved
camel/functions/github_functions.py Outdated Show resolved Hide resolved
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we also add functions like list all the repos, issues, files and PRs? We can do it in the next PR.

camel/functions/github_functions.py Outdated Show resolved Hide resolved
examples/function_call/github_agent.py Outdated Show resolved Hide resolved
examples/function_call/github_agent.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
test/functions/test_github_functions.py Outdated Show resolved Hide resolved
test/functions/test_github_functions.py Outdated Show resolved Hide resolved
@Wendong-Fan Wendong-Fan changed the title Add GitHub integration feat: Add GitHub integration May 19, 2024
@rsrbk rsrbk force-pushed the rsrbk/github-solve-issue branch from 382de58 to 4a7fdcb Compare May 20, 2024 10:48
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I left some comments.

import os
from typing import List

from github import Auth, Github
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don’t want to make PyGithub a mandatory dependency. Could we import it like how we do in other functions: https://github.com/camel-ai/camel/blob/master/camel/functions/search_functions.py. i.e. we import inside the functions.

camel/functions/github_functions.py Outdated Show resolved Hide resolved
camel/functions/github_functions.py Outdated Show resolved Hide resolved
camel/functions/github_functions.py Outdated Show resolved Hide resolved


class GitHubLoaderIssue:
def __init__(self, title, body, number, file_path, file_content):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type hinting and docstrings are still missing. BTW, why not just use dataclass : https://docs.python.org/3/library/dataclasses.html?

def create_pull_request(
self, file_path, new_content, pr_title, commit_message
):
branch_name = f"github-agent-update-{file_path.replace('/', '-')}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not fixed

Comment on lines 66 to 69
file = self.repo.get_contents(file_path)
self.repo.update_file(
file.path, commit_message, new_content, file.sha, branch=branch_name
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not fixed

camel/loaders/github_loader.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
test/functions/test_github_functions.py Outdated Show resolved Hide resolved
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution, left some comments. I'm a little bit confused with the scope, will we set github as one agent or just make it as tool/function for agent to call?

camel/functions/github_functions.py Outdated Show resolved Hide resolved
camel/functions/github_functions.py Outdated Show resolved Hide resolved
camel/prompts/github.py Outdated Show resolved Hide resolved
camel/types/enums.py Outdated Show resolved Hide resolved
examples/function_call/github_agent.py Outdated Show resolved Hide resolved
camel/toolkits/github_toolkit.py Outdated Show resolved Hide resolved
Copy link
Member

@lightaime lightaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!!!

@lightaime lightaime merged commit dbbc995 into master May 25, 2024
6 checks passed
@lightaime lightaime deleted the rsrbk/github-solve-issue branch May 25, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged or Closed
Development

Successfully merging this pull request may close these issues.

[Feature Request] integrate github into CAMEL functions
3 participants