Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove community supported Spring Zeebe SDK references #4065

Merged
merged 9 commits into from
Aug 27, 2024

Conversation

akeller
Copy link
Member

@akeller akeller commented Jul 25, 2024

Description

Connectors is not part of this PR scope.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@akeller akeller added component:docs Documentation improvements, including new or updated content target:8.6 Issues included in the 8.6 release 8.6.0-alpha4 August 2024 alpha release labels Jul 25, 2024
@akeller akeller self-assigned this Jul 25, 2024
Copy link
Contributor

github-actions bot commented Jul 25, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/apis-tools/community-clients/index.md
  • docs/apis-tools/community-clients/spring.md
  • docs/components/best-practices/development/writing-good-workers.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@akeller
Copy link
Member Author

akeller commented Jul 31, 2024

@aleksander-dytko I've set this to Blocked on the DevEx board until Connectors delivers camunda/connectors#2896.

@akeller
Copy link
Member Author

akeller commented Aug 8, 2024

@aleksander-dytko we have a blocker here with Connectors, but do you want me to split this PR and just include the non-Connectors references? How quickly do you want me to remove these?

@akeller akeller added the hold This issue is parked, do not merge. label Aug 12, 2024
@akeller
Copy link
Member Author

akeller commented Aug 12, 2024

@aleksander-dytko I've removed Connectors from the scope of this PR, but do you have a recommendation for what I should do with the Tasklist API tutorial?

Do you want this PR to ship this week? If so, I will do the brute force method and delete remaining references and put at clean up issue into the DevEx backlog. See quick feedback poll here.

@akeller akeller added 8.6.0-alpha5 September 2024 alpha release and removed hold This issue is parked, do not merge. labels Aug 26, 2024
@akeller akeller marked this pull request as ready for review August 26, 2024 19:07
@akeller akeller requested a review from a team August 26, 2024 19:18
Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one one SM reference to the community spring-zeebe project re: connectors as well. I'm not sure if you'd like the attention label on that, too, or to add it to the Connectors ticket so it doesn't get lost, but otherwise good to go from me. 👍

@akeller
Copy link
Member Author

akeller commented Aug 27, 2024

There is one one SM reference to the community spring-zeebe project re: connectors as well. I'm not sure if you'd like the attention label on that, too, or to add it to the Connectors ticket so it doesn't get lost, but otherwise good to go from me. 👍

Can you add it to the Connectors ticket? @conceptualshark

After a DM with @aleksander-dytko yesterday, I'm merging this.

@akeller akeller merged commit e6facde into main Aug 27, 2024
8 checks passed
@akeller akeller deleted the remove-community-supported-spring-sdk branch August 27, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.6.0-alpha5 September 2024 alpha release component:docs Documentation improvements, including new or updated content target:8.6 Issues included in the 8.6 release
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants