-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modeler inline comment plugin does not store the comments #100
Comments
Thanks for reporting this bug. Could you link the resource that you're referring to here? Related, if you find a bug with a plug-in, let's create the bug report there. |
Sure, I took the plugin from here: https://github.com/camunda/camunda-modeler-plugins. It is the bpmn-js-plugin-embedded-comments. I can add an internal note in the modeler session. But after saving the model and close/reopen it, the comment is gone. |
I can reproduce at any time if the internal note is the ONLY change in the model. If there are other changes that are also reflected in the model's title bar with a blue point (indicator that a save is necessary) then the internal note is saved as well. But if I only add an internal note text, the blue point is not shown and the note's text is not saved. |
Thanks for the follow-up, I can reproduce this issue. The modeler does not track moddle changes from external namespaces. Not sure if this is an issue with the modeler or the plugin itself, so I'll reopen this ticket in the meantime |
This is a limitation in the upstream bpmn-js extension. It simply does not change the model in the appropriate way, hence leaving the modeler with no clue that an actual change happened. Moving this issue to the plug-in repository. |
Describe the bug
I installed the plugin: bpmn-js-plugin-embedded-comments ("Embnedded Comments") in Modeler's plugin-directory under Windows 10. Modeler version is 5.10.0. I can add comments during the modelling session. But after save and restart of Modeler, the comments are lost.
Steps to reproduce
Expected behavior
The comments added to a model have to be poersisted after saving the model.
Environment
Additional context
Root cause analysis in #100 (comment).
The text was updated successfully, but these errors were encountered: