Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): migrate to the official Zeebe Spring SDK #3193

Merged
merged 20 commits into from
Nov 8, 2024
Merged

chore(deps): migrate to the official Zeebe Spring SDK #3193

merged 20 commits into from
Nov 8, 2024

Conversation

chillleader
Copy link
Member

@chillleader chillleader commented Aug 28, 2024 •
edited
Loading

Description

This PR will migrate the Connectors project to the official Camunda Spring SDK. Until now, we have been using the community-supported library Spring Zeebe which is now on a deprecation path.

Key changes:

  • All Spring Boot apps are not using the new property structure for authentication-related config
  • A community-supported Operate client is now used. The official Camunda Spring SDK doesn't offer an Operate client yet.
  • All integration tests that had previously used the testing library from Spring Zeebe now use the official Camunda Process Test (CPT) library.
    • ⚠️ This will lead to significant increase in build time - each integration test case now takes 30+ seconds.
    • We can consider build optimizations due to this in a follow-up PR if this impacts our productivity
  • Console Secret API client has been changed: it uses the authentication classes from the Operate client library. The check whether or not it should be enabled is done via the standard Zeebe client properties to cover the use cases where Operate is disabled and no properties are provided.
    • This is subject to change when Operate client becomes part of the Spring SDK.

Related issues

closes #2896

@chillleader chillleader self-assigned this Aug 28, 2024
@chillleader chillleader changed the title chore: migrate to the official Zeebe Spring SDK chore(runtime): migrate to the official Zeebe Spring SDK Aug 28, 2024
@chillleader chillleader changed the title chore(runtime): migrate to the official Zeebe Spring SDK chore(deps): migrate to the official Zeebe Spring SDK Aug 28, 2024
@chillleader chillleader mentioned this pull request Aug 29, 2024
Closed
@chillleader chillleader added this to the 8.7.0-alpha1 milestone Sep 23, 2024
@chillleader chillleader marked this pull request as ready for review October 29, 2024 08:42
@chillleader chillleader requested a review from a team as a code owner October 29, 2024 08:42
sbuettner
sbuettner previously approved these changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@sbuettner sbuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this rather large migration.

Only a small comment but nothing blocking it to be merged.

Does this PR require us to update the helm chart or are variables already available?

@chillleader
Copy link
Member Author

This will most likely require Helm chart updates - I'm going to test it after merging

@chillleader chillleader requested a review from sbuettner November 8, 2024 13:16
mathias-vandaele
mathias-vandaele approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@mathias-vandaele mathias-vandaele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chillleader chillleader added this pull request to the merge queue Nov 8, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 8, 2024
@chillleader chillleader added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit cbfc2f7 Nov 8, 2024
10 checks passed
@chillleader chillleader deleted the move-to-sdk-again branch November 8, 2024 17:40
@tmetzke
Copy link
Member

tmetzke commented Nov 14, 2024

This will most likely require Helm chart updates - I'm going to test it after merging

@chillleader, has this been tackled already or can be followed? I believe this is leading to CI failures like this one.

sbuettner pushed a commit that referenced this pull request Dec 5, 2024
@chillleader @sbuettner
chore(deps): migrate to the official Zeebe Spring SDK (#3193)
97eb254 
* lint

* wip: sdk migration

* wip: sdk migration

* wip: sdk migration

* more adjustments to tests and properties

* fix saas tests

* fix http test

* remove hardcoded old versions

* fix more tests

* fix deps

* fix deps

* adjust logging levels

* bump deps, fix saas tests

* fix saas tests

* fix e2e tests

* fix kafka e2e test

* fix soap e2e test

* lint

* fix email test

* use collections-util
mathias-vandaele added a commit that referenced this pull request Jan 22, 2025
@mathias-vandaele
Revert "chore(deps): migrate to the official Zeebe Spring SDK (#3193)"
b20f176 
This reverts commit cbfc2f7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathias-vandaele mathias-vandaele mathias-vandaele approved these changes

@johnBgood johnBgood Awaiting requested review from johnBgood

@sbuettner sbuettner Awaiting requested review from sbuettner

Assignees

@chillleader chillleader

Labels
None yet
Projects
None yet
Milestone
8.7.0-alpha2
Development

Successfully merging this pull request may close these issues.

Migrate to the official Zeebe client and standalone Operate client
4 participants
@chillleader @tmetzke @sbuettner @mathias-vandaele