get rid of can-util deps #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherifGsoul
requested review from
justinbmeyer,
bmomberger-bitovi and
phillipskevin
and removed request for
bmomberger-bitovi
chasenlehara
requested changes
Jun 29, 2018
package.json
Outdated
| @@ -48,8 +49,8 @@ | |||
| "can-reflect": "^1.6.0", | |||
| "can-simple-map": "^4.0.0", | |||
| "can-simple-observable": "^2.0.0", | |||
| "can-symbol": "^1.0.0", | |||
| "can-util": "^3.9.0" | |||
| "can-string": "0.0.5", | |||
There was a problem hiding this comment.
I think this should be "<2.0.0"
There was a problem hiding this comment.
Yes. We don’t want to pin to a specific version and we should release a 1.0 without breaking compatibility.
Update testee to the latest version 🚀
chasenlehara
previously requested changes
Jul 3, 2018
package.json
Outdated
| @@ -1,67 +1,68 @@ | |||
| { | |||
| "name": "can-route", | |||
There was a problem hiding this comment.
The spacing needs to be reverted back to what it was.
justinbmeyer
approved these changes
Jul 3, 2018
|
I thought I would take care of it ... but I will probably do this in another branch |
|
@justinbmeyer you closed it at the same moment it was fixed! can we open it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for canjs/canjs#4218