IE8 error

[daffl]

observe.js line 422 throws this error in IE9 (IE8 mode). I haven't had a chance to test it in the real IE8.

SCRIPT5028: Function.prototype.apply: Array or arguments object expected

I changed the line from this:

this.push.apply(this, instances || []);

to this:

this.push.apply(this, can.makeArray(instances || []));

and now it works fine. instances was an observable list so even though it had items (indexable items) IE doesn't recognize it as an array.

[daffl]

Looks like a good fix to me. Could you provide a small test case that breaks in IE so that we can add it to our unit tests?

Or, even better and which would get you in our list of heroes in no time, a pull request with the breaking test and the fix?

[daffl]

Allright I added the tests, pull request attached. Thanks again for reporting this!