[MISC] Fix smoke test #1184
Merged
[MISC] Fix smoke test #1184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
added
the
not bug or enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1184 +/- ##
=======================================
Coverage 75.74% 75.74%
=======================================
Files 16 16
Lines 4164 4164
Branches 629 629
=======================================
Hits 3154 3154
Misses 790 790
Partials 220 220 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
force-pushed
the
volumes-tests
branch
from
04967a3 to
bbc6b54
Compare
dragomirp
commented
Sep 24, 2025
Comment on lines
+145
to
+147
| deploy_cmd = f"deploy ./{charm} {DUP_APPLICATION_NAME} --model={ops_test.model.info.name} --attach-storage={garbage_storage} --config profile=testing".split() | ||
| return_code, _, _ = await ops_test.juju(*deploy_cmd) | ||
| assert return_code == 0, "Failed to add unit with storage" |
There was a problem hiding this comment.
Call juju deploy directly. Libjuju fails with:
juju.errors.JujuAPIError: AttachStorage may not be specified for container models
marceloneppel
approved these changes
Sep 24, 2025
taurus-forever
approved these changes
Sep 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Checklist