Skip to content

[MISC] Fix smoke test #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

[MISC] Fix smoke test #1184

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7e7db40
Volume tests
dragomirp Sep 23, 2025
bbc6b54
Manually deploying
dragomirp Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions tests/integration/ha_tests/test_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import logging

import pytest
from juju import tag
from pytest_operator.plugin import OpsTest
from tenacity import Retrying, stop_after_delay, wait_fixed

Expand Down Expand Up @@ -143,14 +142,9 @@ async def test_app_resources_conflicts_v3(ops_test: OpsTest, charm: str):
garbage_storage = await get_any_deatached_storage(ops_test)

logger.info("deploying duplicate application with attached storage")
await ops_test.model.deploy(
charm,
application_name=DUP_APPLICATION_NAME,
num_units=1,
base=CHARM_BASE,
attach_storage=[tag.storage(garbage_storage)],
config={"profile": "testing"},
)
deploy_cmd = f"deploy ./{charm} {DUP_APPLICATION_NAME} --model={ops_test.model.info.name} --attach-storage={garbage_storage} --config profile=testing".split()
return_code, _, _ = await ops_test.juju(*deploy_cmd)
assert return_code == 0, "Failed to add unit with storage"
Comment on lines +145 to +147
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Call juju deploy directly. Libjuju fails with:

juju.errors.JujuAPIError: AttachStorage may not be specified for container models


# Reducing the update status frequency to speed up the triggering of deferred events.
await ops_test.model.set_config({"update-status-hook-interval": "10s"})
Expand Down