feat(ColumnSelector): create a component that can toggle columns of a table #1259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
edlerd
reviewed
Oct 2, 2025
Contributor
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Thanks for raising this upstream. Some comments and ideas for the structure below.
edlerd
reviewed
Oct 2, 2025
Contributor
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
Tests, Stories and QA LGTM
Please extend on docs and some small nitpicks on naming.
… table Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
kimanhou
force-pushed
the
WD-4728-lxd-ui-column-toggle
branch
from
193072a to
46d0c82
Compare
edlerd
approved these changes
Oct 6, 2025
Contributor
edlerd
left a comment
edlerd
left a comment
There was a problem hiding this comment.
QA and Code LGTM, thanks for upstreaming :)
edlerd
added
Review: Code +1
Review: QA +1
Review: Percy +1
and removed
Review: Code needed
Review: QA needed
Review: Percy needed
labels
|
🎉 This PR is included in version 3.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
Percy steps
Screenshot after Cluster Member column was untoggled:
