-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migration lint #1545
chore: migration lint #1545
Conversation
d1ca992
to
ee4406c
Compare
@OlkaB could you review this one? It's a lot of changes but most are related to the strict linting. |
@@ -30,8 +30,7 @@ const { disabled, icon, kind, size } = commonCvButtonProps; | |||
|
|||
export default { | |||
name: 'CvIconButton', | |||
components: { CvSvg }, | |||
emits: ['click'], // emitted to allow testing of click | |||
components: { CvSvg }, // emitted to allow testing of click |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the comment probably should go with moved 'emits' (to line 73)
@@ -44,7 +44,7 @@ | |||
<span data-items-selected> | |||
<slot | |||
name="items-selected" | |||
v-bind:scope="{ count: dataRowsSelected.length }" | |||
:scope="{ count: dataRowsSelected.length }" | |||
>{{ dataRowsSelected.length }} items selected</slot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
side note/question: shouldn't user facing strings be passed as some props or be slotted (for potential language localization purposes)?
:placeholder="placeholder" | ||
:aria-labelledby="uid" | ||
:disabled="disabled ? 'true' : undefined" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
following compatibility mode comment, might be that also here it should be changed to :disabled="disabled || null" ?
:id="cvId" | ||
:aria-invalid="isInvalid || null" | ||
:aria-describedby="isInvalid ? errorId : undefined" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't there be null instead of undefined?
@@ -30,8 +30,7 @@ const { disabled, icon, kind, size } = commonCvButtonProps; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated story
- Get tip alignments fom '../CvTooltip/consts.js';
- Fix warnings from story book about deprecated format.
- Add control for tipAlignment
@@ -13,22 +13,27 @@ const props = defineProps({ | |||
sm: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is definitely related to the lint changes. For the lint errors I added default: undefined
for the break-point size and this is causing the error. Updated to default: false
@@ -2,12 +2,12 @@ | |||
<div :class="`cv-pagination ${carbonPrefix}--pagination`" data-pagination> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unrelated to this PR but I "fixed" it.
@felipebritor looks like you added this to .storybook/styles.scss
// set space between form items
.bx--form-item {
margin-bottom: 2rem;
}
I'm sure I broke something by removing it so maybe have a look and add it to a story instead of to the style?
@davidnixon Review finished. I've caught some additional issues but they might be better candidates to separate issue tickets. |
What did you do?
[Vue warn]: injection "selectable" not found.
[Vue warn]: (deprecation ATTR_FALSE_VALUE) Attribute "aria-invalid" ...
. To resolve many templates are updated like this:Why did you do it?
How have you tested it?
With local app and the jest tests
Were docs updated if needed?