-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JAWS does not announce popup after column selection #5242
Comments
@dakahn Is this reproducible...? Thanks! |
Can confirm. Batch actions toolbar is not announced. :| Tested with JAWS 2020 on latest Firefox in Windows 10 |
@carmacleod Just in case you have some insights... Does ARIA have a notion of "contextual action bar", where an action bar appears only in certain context? Thanks! |
ARIA can be used to indicate that an input like a button or checkbox controls the visibility of a container element. See the spec for aria-expanded. So if each checkbox has aria-expanded="true/false" and uses aria-controls to point to the id of the section element, then that should be helpful. I have some other suggestions as well (based on the code sandbox example):
|
This change uses a combination of `aria-expanded`/`aria-controls` so we give the table selection checkbox a mean to show/hide batch action bar. Also does the following as suggested in carbon-design-system#5242: * Hide the batch action bar from screen reader when we are visiblly hiding it * Remove `aria-label` from the batch action bar * Remove `aria-live="polite"` from `<tbody>` Fixes carbon-design-system#5242.
Please, at a minimum, remove the |
Ok, this is "Take two", because my original suggestion (aria-expanded & aria-controls on the checkboxes) would have resulted in a very chatty and confusing experience for screen reader users so I asked for it not to be merged. For example navigating to and checking the first 2 checkboxes would have resulted in the following:
New list of suggestions:
With the above markup, screen reader users will be able to navigate to the toolbar using landmark navigation (shift+R in JAWS, shift+D in NVDA, control+option+U for VO rotor), or, if a title prop was given for the TableContainer, then a simple shift+H will go to the h4, and Tab key will go to the toolbar (if you can guarantee that the title prop is there - even if it's offscreen - please let me know, because I might change the markup a bit to remove the region). Alternatively, if there are multiple tables on the page, the next table/previous table keystrokes (T and shift+T) will take them to the top of the table, and then they can type shift+tab to go to the toolbar. JAWS has a keystroke for "go to first cell in table" (from which shift+tab goes to the toolbar), but other screen readers don't have that, and it's pretty esoteric, so even JAWS users might not know it. Unfortunately, keyboard users will still have to use shift+tab multiple times to go back to the toolbar. The only way around that is to give them a keyboard shortcut for "go to toolbar" and make sure it's discoverable in doc, and maybe also in live region, i.e. "Batch actions toolbar available, type [keys] to focus." I guess keyboard users could also use the landmarks plugin to navigate quickly to the toolbar region. Before someone starts working on this issue, I would like to run this by a few folks to see if they agree with these suggestions. I will report back here after that. |
Many of the things @carmacleod is suggesting gel with prior work I did on operable tables and thoughts I had when considering how to have a good experience of batch controls that appear On Input, above the focal point, including:
I do have some thoughts about ways to improve the default label for row selection inputs (be they radio buttons or checkboxes). Effectively, make the first cell in the row that doesn't contain the input into the label (or part of the label or described by) for the input. You could also make the label cell a knob setting, for a situation where the first cell is NOT the best row header option. |
One thing I don't see addressed here in my quick read through is focus handling, both
This is an existing problem, not one introduced by her proposal. |
Good point about focus handling. In Outlook Mail, for example, if you delete a message focus goes to the next item. If there is no next item, focus goes to the previous item. This makes sense to me. The next focus handling point above is tricky. Currently, after the cancel button is pressed, focus stays on the cancel button. (I presume that if a Cancel dialog was opened, e.g. to say "Are you sure?", then focus would return to the cancel button.) This seems ok, because tab forward now goes to the next focusable item after the (invisible) Cancel button, i.e. the next row checkbox, and shift+tab goes to whatever focusable element is before the invisible Cancel button in the tab order. The weird part is that because the Cancel button is invisible, there's no focus ring anywhere. Not sure what to do about that. |
Hi there! 👋 You may have seen that v10 reached it's end of support on September 30, 2024. In the interest of keeping a tidy issue queue, issues flagged as relating to v10 will be closed. If this issue is still relevant, please open a new issue with a link to this issue and a reproduction that uses v11. Thanks again for your participation and contributions to this issue and the Carbon ecosystem! 💙 |
Environment
Detailed description
Steps to reproduce the issue
https://codesandbox.io/s/tablebatchaction-not-announced-by-jaws-od5r6
Additional information
The text was updated successfully, but these errors were encountered: