fix(file-uploader): ensure form requirements are visible #6867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 083cf48 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 083cf48 https://deploy-preview-6867--carbon-components-react.netlify.app |
joshblack
approved these changes
Sep 22, 2020
|
bump @andreancardona when you get a sec today |
andreancardona
approved these changes
Sep 22, 2020
tw15egan
requested review from
a team and
johnbister
and removed request for
a team
|
Looks good to me! |
johnbister
approved these changes
Sep 22, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
This was referenced Sep 24, 2020
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6866
This PR adds a style rule which ensures that form requirements for invalid file uploader contents are visible
Testing / Reviewing
Add an invalid file in a file uploader demo and confirm that the error details are visible