feat(OverflowMenuItem): support title prop
#7277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Deploy preview for carbon-elements ready! Built with commit 0a7750b |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 0a7750b https://deploy-preview-7277--carbon-components-react.netlify.app |
dakahn
approved these changes
Nov 12, 2020
22 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #7088
This PR allows users to set a
titleprop in the event that the tooltip text should be different from theitemTextChangelog
New
titleattribute support in OverflowMenuItemChanged
title(when a custom value is provided/not provided)Testing / Reviewing
Confirm that setting a
titletogether with the existingrequireTitlefunctions properly