feat(Tabs): add control for autoscroll on component rerender #7410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit ba396b2 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit ba396b2 https://deploy-preview-7410--carbon-components-react.netlify.app |
emyarod
force-pushed
the
7399-boolean-toggle-autoscroll-into-view
branch
from
1b2d8ad
to
2d16dde
Compare
dakahn
approved these changes
Dec 8, 2020
This was referenced Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7399
This PR adds a boolean control for controlling tab autoscroll behavior on component rerenders only
Changelog
New
scrollIntoViewpropTesting / Reviewing
Confirm that the newly added control only impacts auto scroll behavior on component rerenders, particularly from prop updates