test(Checkbox): add accessibility unit tests and docs #7422
Conversation
|
|
||
| it('should have no Axe violationk', async () => { | ||
| render(<Checkbox labelText="Checkbox label" id="test_id" />); | ||
| await expect(screen.getByText('Checkbox label')).toHaveNoAxeViolations(); |
There was a problem hiding this comment.
Will this check the whole checkbox component or the node that this text is inside? (Or does this selector get both? lol)
There was a problem hiding this comment.
ah! great catch. I was using the wrong selector query there and it was returning just the span with that text in it 🤦🏽
.getByLabelText() is what I wanted here which returns
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: ea0c108 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd7a860d34cbf00080234a0 😎 Browse the preview: https://deploy-preview-7422--carbon-elements.netlify.app |
|
Deploy preview for carbon-components-react ready! Built with commit 8cd37a0 https://deploy-preview-7422--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built with commit ea59621 https://deploy-preview-7422--carbon-components-react.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit ea0c108 https://deploy-preview-7422--carbon-components-react.netlify.app |
Co-authored-by: Josh Black <josh@josh.black>
Closes #7364
Testing / Reviewing
run
yarn test Checkbox-test.jsand see that there are no errors