fix(pagination): prevent page controls from stacking vertically #7427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 4a4cd3f 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd275a78c2439000835382b 😎 Browse the preview: https://deploy-preview-7427--carbon-elements.netlify.app |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 4a4cd3f https://deploy-preview-7427--carbon-components-react.netlify.app |
emyarod
force-pushed
the
7424-pagination-spacing-regression
branch
from
336e181
to
485f419
Compare
andreancardona
approved these changes
Dec 10, 2020
tw15egan
approved these changes
Dec 10, 2020
laurenmrice
approved these changes
Dec 10, 2020
tw15egan
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7424
Related #7316
also closes #7444
#7316 modified the pagination component padding while trying to address the issue of vertically stacking pagination controls at certain screen sizes. This PR reimplements the vertical stacking fix while avoiding padding changes to maintain visual consistency
Changelog
Changed
Testing / Reviewing
Confirm that the pagination controls do not stack vertically at any screen size and ensure that the component matches the visual spec