Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Popover): add to @carbon/styles #9257

Merged
merged 11 commits into from
Aug 2, 2021

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Jul 22, 2021

Adds Popover to @carbon/styles

Testing / Reviewing

Check out how i'm bringing in popover in Popover/index.js. Almost certain this isn't how we want to do this. Also @joshblack as for showing usage in a Story -- I used the same style as we had in experimental, but that might be more than we want for stable lemme know.

@dakahn dakahn requested a review from joshblack July 22, 2021 23:10
@dakahn dakahn requested a review from a team as a code owner July 22, 2021 23:10
@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3960e2e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61080595c4650000070a3ccb

😎 Browse the preview: https://deploy-preview-9257--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 9fac9f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60f9fae444b256000790832c

😎 Browse the preview: https://deploy-preview-9257--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 9fac9f4

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60f9fae496c4cc000855643b

😎 Browse the preview: https://deploy-preview-9257--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jul 22, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3960e2e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61080595036a29000882492c

😎 Browse the preview: https://deploy-preview-9257--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jul 22, 2021

❌ Deploy Preview for carbon-components-react failed.
Built without sensitive environment variables

🔨 Explore the source changes: 3960e2e

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61080595fea29000078ce592

@dakahn dakahn mentioned this pull request Jul 23, 2021
62 tasks
@andreancardona
Copy link
Contributor

@dakahn I think testing needs to be updated

@kodiakhq kodiakhq bot merged commit f33d65c into carbon-design-system:main Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants