Skip to content

Add notice to readme #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 14, 2021
Merged

Add notice to readme #283

merged 3 commits into from
Jan 14, 2021

Conversation

avanbrunt-cb
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Tests have been added that prove the fix is effective or that the feature works.
  • New and existing tests pass locally with the changes.
  • Code follows the style guidelines of this project (PEP8, clean code).
  • Linter has passed locally and any fixes were made for failures.
  • A self-review of the code has been done.

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes (not tied to bugs/features)
  • Other (please describe):

What is the ticket or issue number?

CBAPI-2235

Pull Request Description

Add notice to readme of transition for Carbon Black Cloud

Does this introduce a breaking change?

  • Yes
  • No

How Has This Been Tested?

N/A

kebringer-cb
kebringer-cb approved these changes Jan 14, 2021
View reviewed changes
Copy link
Contributor

@kebringer-cb kebringer-cb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. A minor suggestion to wording after the new notice.

README.md Outdated

_**Notice**: The Carbon Black Cloud portion of CBAPI has moved to https://github.com/carbonblack/carbon-black-cloud-sdk-python. Any future development and bug fixes for Carbon Black Cloud APIs will be made there. Carbon Black EDR and App Control will remain supported at CBAPI_

These are the new Python bindings for the Carbon Black Enterprise Response and Enterprise Protection REST APIs.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're probably not "new" bindings at this stage. Change the sentence to
"These are the Python bindings..."

@avanbrunt-cb avanbrunt-cb merged commit e4da280 into master Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abowersox-cb abowersox-cb Awaiting requested review from abowersox-cb

@lhilmes-cb lhilmes-cb Awaiting requested review from lhilmes-cb

@mrangelov-cb mrangelov-cb Awaiting requested review from mrangelov-cb

@emitreva-cb emitreva-cb Awaiting requested review from emitreva-cb

2 more reviewers

@kebringer-cb kebringer-cb kebringer-cb approved these changes

@hkaragitliev-cb hkaragitliev-cb hkaragitliev-cb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@avanbrunt-cb @kebringer-cb @hkaragitliev-cb