Skip to content

Conversation

zacharyestep
Copy link
Contributor

@zacharyestep zacharyestep commented Jan 28, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • [ x] Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • [ x] Tests have been added that prove the fix is effective or that the feature works.
  • [ x] New and existing tests pass locally with the changes.
  • [x ] Code follows the style guidelines of this project (PEP8, clean code).
  • [x ] Linter has passed locally and any fixes were made for failures.
  • [ x] A self-review of the code has been done.

Pull request type

Bugfix/issue

Please check the type of change your PR introduces:

  • [+ ] Bugfix

What is the ticket or issue number?

cb-38082

Pull Request Description

One line change to change the sort order for EDR sensor searches from 'last_checkin_time' (default when none provided explicitly) to 'hostname' to make the sort stable as sensors checkin during paging

Does this introduce a breaking change?

  • Yes
  • [+ ] No

How Has This Been Tested?

Manual testing

`from cbapi.response import CbResponseAPI, Sensor
import logging
logging.basicConfig(level=logging.DEBUG)

cb=CbResponseAPI()
cb_sensors = cb.select(Sensor).all()
sensors = list(cb_sensors)
`

Other information:


@kebringer-cb kebringer-cb changed the base branch from master to develop January 28, 2022 15:37
@kebringer-cb kebringer-cb merged commit edaf90c into develop Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] API len(cb.select(Sensor)) causes error when >1000 sensors

3 participants