Drop spikeextractor backend support for NeuralynxRecordingInterface #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov Report
@@ Coverage Diff @@
## main #174 +/- ##
==========================================
- Coverage 91.53% 91.49% -0.05%
==========================================
Files 65 65
Lines 3391 3375 -16
==========================================
- Hits 3104 3088 -16
Misses 287 287
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodyCBakerPhD
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we drop support for spikextractor backend support for NeuralynxRecordingInterface. The reason for this is that the old backend does not support multi segment extractor. Plus, this should should make #170 way more simple to implement. I still need to add tests for multi segment neuralynx data but this is a simplifying step into that direction.