stub Movie interface timestamps #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2022
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 90.76% 91.50% +0.73%
==========================================
Files 65 65
Lines 3423 3425 +2
==========================================
+ Hits 3107 3134 +27
+ Misses 316 291 -25
Flags with carried forward coverage won't be shown. Click here to find out more.
|
CodyCBakerPhD
approved these changes
Oct 19, 2022
|
I do wish there was a lazier way of getting the timestamps to begin with, but I guess that takes us out of the OpenCV territory so a bit bigger undertaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working in the current conversion with Murthy I am facing with some rather large video files and stubbing is very useful for fast iteration. However, the timestamps themselves are not stubbed and OpenCV goes frame by frame through the whole video rendering the stubbing process useless (even in
external_mode=True). This PR implements stubbing in the timestamp extraction as well limiting the frame reading in OpenCV.I added a test and tested this on the Murthy conversion.