feat: configurable alarm severities #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <github-actions@github.com>
|
Did you see #1767? Wonder if orchestration failure should be medium severity instead. |
iankhou
reviewed
Jul 21, 2025
src/package-sources/npmjs.ts
Outdated
| // there is nothing that can be done from our end, besides waiting for the replica to be all | ||
| // caught up. | ||
| monitoring.addLowSeverityAlarm( | ||
| monitoring.addMediumSeverityAlarm( |
There was a problem hiding this comment.
Note that this is the first time we are using addMediumSeverityAlarm anywhere. Not an issue in itself, but this alarm will not initialize without alarmActions.mediumSeverity.
There was a problem hiding this comment.
Yeap. I'm actually revising this PR to support configurable severities, which won't change the default here.
iliapolo
changed the title
auto-merge was automatically disabled
July 21, 2025 07:30
Pull request was converted to draft
Yeah, maybe you're right. Lets discuss in ops. |
iliapolo
changed the title
mrgrain
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup on an internal team discussion:
Backend Orchestration Failed
This alarm fires on a single execution failure -> setting it to a high severity is too harsh because sporadic singular failures can happen from time to time, and its not an indication of a severe problem.
Given we also have a high severity alarm for when execution failure rate is above 75%, we want to set this alarm to be low severity.
New version visibility SLA breached
This alarm fires when the package canary is not ingested in time, according to the defined SLA. It is, presumably, an indication of a major problem because the package is predictable and processable. However, this alarm is also impacted by the npm replica, which, from to time, experiences significant delays out of our control. We therefore decided to set it to a low severity initally.
Since then, we have increased our SLA and the replica itself has also undergone substantial changes. Seems like an appropriate timing to start increasing the severity.
Note
We could have also just changed the severities, without providing a way to configure them. This however would be a breaking change. Construct hub is not a stable package, so we would have gotten away with it, but I decide to play it safe.
Configurable severities seems like a good feature to have anyway.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license