fix: DLQ alarm can fire spuriously #1779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DLQ alarms includes the `ApproximateMessagesNotVisible` metric. That metric can behave unpredictably, sometimes approximating 1 even if there are no messages in the DLQ at all. Since there are no readers on a DLQ (usually), the number of messages in flight will usually be 0. No need to include this in the alarm then.
iliapolo
approved these changes
Aug 28, 2025
Signed-off-by: github-actions <github-actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DLQ alarms includes the
ApproximateMessagesNotVisiblemetric. That metric can behave unpredictably, sometimes approximating 1 even if there are no messages in the DLQ at all.Since there are no readers on a DLQ (usually), the number of messages in flight will usually be 0. No need to include this in the alarm then.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license