Query parameters break IDE

[garagatyi]

I tried to use code-server in a container on Openshift inside of Che as an alternative to Eclipse Theia. Che adds query parameter ?uid=213488 to ensure that response is not cached and updates of the IDE web page are properly managed.
But code-server doesn't load because of this query parameter. Instead error is returned
Cannot GET / with error code 404.
Changing query parameter name doesn't help.
Could you allow passing query parameters to the IDE, so caching prevention would work?
Actually, it might be a good idea to prevent caching by default because some users would want to be able to run new version of the code-server in a docker container and not suffer from cached page issue.

[sr229]

From what I can understand, the http server they coded this at only listens to / so any query params can break the implementation quite easily.

EDIT: This is also a issue when running it in Cloud Shell as well.

[sr229]

CC any coder maintainer to mark this as a bug and not a feature thanks

[nir0s]

This is actually a blocker for me. I'm using a reverse-proxy which identifies origin by a query param.

[kylecarbs]

Ah. I guess we'll need to add query params when we make requests.

[sr229]

@kylecarbs I think this is high priority since we have a large audience that has reverse proxies. This would be a pain in the ass for them (and for integrators who want to add this toolchain to their own solution)

[grenovales]

I got it running on my environment with a hack

Basically, I have code-server running outside of Eclipse Che, and created a stack with a docker image with a simple HTTP server in python redirecting to code-server. It is not a secure environment but this is my internal network and is just me 👍

[sr229]

sounds like a acceptable workaround but this needs to be fixed upstream

[grenovales]

sounds like a acceptable workaround but this needs to be fixed upstream

agreed

[jeasonstudio]

Any progress?

[sr229]

I have not heard from our folks at Coder but I'll go ahead CC one so they'll be updated about the need for this fix.

CC @deansheather