improv: Make regen consume items more reliably #6799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6799 +/- ##
=======================================
Coverage 70.73% 70.73%
=======================================
Files 138 138
Lines 16605 16615 +10
Branches 2094 2098 +4
=======================================
+ Hits 11745 11753 +8
- Misses 4663 4664 +1
- Partials 197 198 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request introduces 1 alert when merging 08066a1 into 799f839 - view on LGTM.com new alerts:
|
This change introduces a helper method which abstracts the logic of consuming items one by one in `regen` and also introduces a single lookahead to ensure that the `__done` property gets set even if the regen is not fully iterated, fixing an edge case where a repeatable iterator would get doubled when used as a base for a `regen` instance.
maybe-sybr
force-pushed
the
improv/regen-lazy-consumption
branch
from
08066a1
to
645c0ef
Compare
|
This pull request introduces 1 alert and fixes 1 when merging 645c0ef into 5d72aee - view on LGTM.com new alerts:
fixed alerts:
|
auvipy
approved these changes
Jun 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up to #6789 with some more significant changes to the
regenimplementation to:
__getitem__()** this fixes an edge case where a repeating underlying iterator could be duplicated if regen is not fully iterated
** element duplication from repeatable underlying iterables is not generally fixed since we still store the iterable not its iterator (IIUC)