Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/header: Implement basic header Service structure and interfaces #148

Merged
merged 3 commits into from
Nov 3, 2021
Merged

service/header: Implement basic header Service structure and interfaces #148

merged 3 commits into from
Nov 3, 2021

Conversation

renaynay
Copy link
Member

This PR implements header Service as well as adds two interfaces: Exchange and Store that cover the behaviours necessary for a node to retrieve/provide ExtendedHeaders from/to the network, as well as store/retrieve those ExtendedHeaders from the node's local storage.

Related to #24

@renaynay renaynay added the area:header Extended header label Oct 25, 2021
@Bidon15 Bidon15 mentioned this pull request Oct 25, 2021
Closed
liamsi
liamsi reviewed Oct 26, 2021
View reviewed changes
service/header/types.go Outdated Show resolved Hide resolved
service/header/types.go Outdated Show resolved Hide resolved
service/header/types.go Outdated Show resolved Hide resolved
@renaynay renaynay requested a review from liamsi October 27, 2021 09:14
@renaynay
Copy link
Member Author

Needs to be rebased on #153 (so that one has to be merged first)

@renaynay renaynay force-pushed the header-service branch 2 times, most recently from 1dfa2ef to 627713b Compare November 1, 2021 11:09
@renaynay renaynay mentioned this pull request Nov 1, 2021
Merged
adlerjohn
adlerjohn reviewed Nov 1, 2021
View reviewed changes
service/header/header.go Outdated Show resolved Hide resolved
service/header/interface.go Outdated Show resolved Hide resolved
liamsi
liamsi previously approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The interfaces make sense and look good to me. I think the actual implementation will make things even clearer.

@renaynay
Copy link
Member Author

renaynay commented Nov 1, 2021

@liamsi implementation is here #160

Wondertan
Wondertan reviewed Nov 2, 2021
View reviewed changes
service/header/interface.go Outdated Show resolved Hide resolved
service/header/interface.go Show resolved Hide resolved
service/header/interface.go Show resolved Hide resolved
service/header/interface.go Outdated Show resolved Hide resolved
service/header/header.go Outdated Show resolved Hide resolved
service/header/header.go Outdated Show resolved Hide resolved
liamsi
liamsi approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@liamsi liamsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨

Wondertan
Wondertan approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@Wondertan Wondertan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!
:shipit:

@Wondertan
Copy link
Member

Wondertan commented Nov 3, 2021 •
edited
Loading

The test is failing due to known #154, re-running...

@renaynay renaynay merged commit fcb00dc into celestiaorg:main Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamsi liamsi liamsi approved these changes

@Bidon15 Bidon15 Bidon15 left review comments

@Wondertan Wondertan Wondertan approved these changes

@adlerjohn adlerjohn adlerjohn approved these changes

@mattdf mattdf Awaiting requested review from mattdf

Assignees
No one assigned
Labels
area:header Extended header
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@renaynay @Wondertan @Bidon15 @adlerjohn @liamsi