service/header: implement HeaderSub #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renaynay
force-pushed
the
header-sub
branch
3 times, most recently
from
195b6c0
to
6652595
Compare
|
This PR depends on #148 being merged first. |
renaynay
changed the title
liamsi
reviewed
Nov 2, 2021
renaynay
force-pushed
the
header-sub
branch
2 times, most recently
from
197d8b3
to
b8280f9
Compare
Wondertan
approved these changes
Nov 4, 2021
adlerjohn
reviewed
Nov 4, 2021
adlerjohn
approved these changes
Nov 5, 2021
|
Waiting on @liamsi for conversation resolution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a structure for HeaderSub, exposing an interface for any service / component that needs access to new
ExtendedHeaders to be able to subscribe to newExtendedHeaderevents.Resolves #164.
Related to #24.