Skip to content

Conversation

amymok
Copy link
Contributor

@amymok amymok commented Jul 7, 2017

This makes use of the renderer functionality DRF provided. This eliminates the use of HttpResponse.

Additions:

  • Added CSVRenderer, XLSRenderer, and XLSXRenderer

Removals:

  • Removed the use of HttpResponse for non-json response

Changes:

  • change the query paramter fmt to format so we can make use of the default usage of DRF renderer

Tests:

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f21080d on amymok:use-renderer into f2a3503 on cfpb:master.

@sephcoster
Copy link
Contributor

This looks super tidy and should help make sure our returns are properly formatted as new formats appear and get updated. Nice! 👍

@amymok amymok merged commit 6e91bd3 into cfpb:master Jul 10, 2017
AdamZarger pushed a commit to AdamZarger/ccdb5-api that referenced this pull request Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants