Skip to content

Conversation

amymok
Copy link
Contributor

@amymok amymok commented Jul 8, 2017

Pulled out the elasticsearch body building to separate body builders to make it easier to identify the different building parts.

This PR branches off from PR #13, you can start reviewing from commit e9af19b until that PR is merged.

Additions:

  • Added builders to separate out building search, post-filter, and aggregation body

Removals:

  • Remove building search, post-filter, aggregation body in es_interface.py

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 58977de on amymok:refactor-esbody into f2a3503 on cfpb:master.

Copy link
Contributor

@JeffreyMFarley JeffreyMFarley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better organization

@amymok amymok merged commit beac47a into cfpb:master Jul 10, 2017
AdamZarger pushed a commit to AdamZarger/ccdb5-api that referenced this pull request Sep 22, 2017
Implement cards according to the design spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants