Skip to content

Conversation

amymok
Copy link
Contributor

@amymok amymok commented Jul 27, 2017

This is to implement query string query search when keyword "AND", "OR", "NOT", or "TO" are found in search_term parameter.

Additions:

  • Added the use of query string query after above keywords are found in search_term

Changes:

  • Moved the base query to the initialized body

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 8513296 on amymok:query-string-query into 671eec1 on cfpb:master.

"query": self.params.get("search_term"),
"operator": "and"
if any(keyword in self.params.get("search_term")
for keyword in ("AND", "OR", "NOT", "TO")):
Copy link
Contributor

@AdamZarger AdamZarger Jul 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this is a loop that does nothing. Was this intentional? Otherwise everything looks great!

Edit: I realize now that I misread this line, ignore my earlier comment.

Copy link
Contributor

@AdamZarger AdamZarger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amymok amymok merged commit 8c79f95 into cfpb:master Jul 28, 2017
AdamZarger pushed a commit to AdamZarger/ccdb5-api that referenced this pull request Sep 22, 2017
imuchnik added a commit that referenced this pull request Apr 30, 2021
higs4281 pushed a commit that referenced this pull request Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants