Add aggregations with filters #7
Conversation
amymok
changed the title
complaint_search/es_interface.py
Outdated
| Field('product', 'Product / Subproduct', 10000, True), | ||
| Field('issue', 'Issue / Subissue', 10000, True), | ||
| Field('state', 'State', 50, False), | ||
| Field('zip_code', 'Zip code', 1000, False), |
There was a problem hiding this comment.
Is zip code really 1000 characters?
There was a problem hiding this comment.
Also, I think the short field names are more appropriate to exchange in the aggs rather than the longer titles
There was a problem hiding this comment.
@JeffreyMFarley This is the size of the results being returned, not the # of characters in the zip code field. I will also take a look at what makes sense for each field as well.
There was a problem hiding this comment.
Okay I will use the short name and leave it to the front-end to handle the title.
| @@ -36,11 +37,307 @@ def test_search_no_param__valid(self, mock_rget, mock_search): | |||
| "fragment_size": 500 | |||
| }, | |||
| "sort": [{"_score": {"order": "desc"}}], | |||
| "post_filter": {"and": {"filters": []}} | |||
| "post_filter": {"and": {"filters": []}}, | |||
| "aggs": { | |||
There was a problem hiding this comment.
I was thinking, how in the world is the test file 9K lines? I see now it is due to lots of embedded JSON to validate the responses.
It's fine, but you could always store them as static files in the same directory and keep the test file focused on the test, not the expected data. Here's my version of that pattern
# -------------------------------------------------------------------------
# Helper Methods
# -------------------------------------------------------------------------
def to_absolute(self, fileName):
import os.path
# where is this module?
thisDir = os.path.dirname(__file__)
return os.path.join(thisDir, fileName)
def load(self, shortName):
import json
fileName = self.to_absolute(shortName + '.json')
with open(fileName, 'r') as f:
return json.load(f)
# -------------------------------------------------------------------------
# Test Methods
# -------------------------------------------------------------------------
def test_search_no_param_valid(self):
expected = self.load('search_no_param_valid')
actual = ...
self.assertEqual(actual, expected)| "sub_product": "sub_product.raw", | ||
| "issue": "issue.raw", | ||
| "sub_issue": "sub_issue.raw" | ||
| } |
There was a problem hiding this comment.
add company_public_response.raw and consumer_consent_provided.raw
There was a problem hiding this comment.
Currently company_public_response.raw and consumer_consent_provided.raw are currently not in the mappings, so it may not work at this moment. @AdamZarger Can you add them to the mapping and I will do the same here for the API
|
Will merge this in for now. |
Use the latest CSS markup for pagination controls
This is to add aggregations as part of the search.
Additions:
Notes:
This PR does not include the following, but the following items will be worked on in later PRs:
Reviews:
@JeffreyMFarley @AdamZarger
cc @sephcoster