-
-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coveralls/Coverage Badge Not Working #927
Comments
Looks like it was purposefully removed back in early 2014 due to reliability concerns per #236. The lone 2015 build coverage must've been submitted manually. |
So, do you think we should re-enable it? IMO we should either enable it or remove the coverage badge. It makes no sense to have coverage information that is not accurate. |
I don't have a strong opinion. I guess my preference would be to remove the badge for now and then add the badge and functionality back in after we refactor Chai to not use makefiles. |
Hello guys 😄 , i have some news. |
I was looking at codecov, investigating if we can move to that. It is more actively worked on and it is part of the GitHub marketplace. |
No more response, i guest the other are agree? Shall i work on it? |
preview: I notice when we integrate codecov app we will get comment on PR, i hope it will give an ease to our outstanding maintainer 😄 . CMIIW |
The reason of change mentioned on chaijs#927 This patch: - add codecov as devDep, as it's not pre-installed by travis. - add codecov script on travis. - change badge link (coverall to codecov), and point the image to chai account on codecov. Fix chaijs#927
Hi folks,
So, I was reviewing one of @meeber's recent PR and I noticed our coveralls reports (and therefore our coverage badge) is not working.
As you can see in this link the most recent build happened in 2015.
I'll take a look at it this weekend but if any of you have any ideas on why this is happening please let me know.
Thanks 😄
The text was updated successfully, but these errors were encountered: