Fix missing msg argument for change related assertions #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, but could you also please change the doc strings above each method to reflect the change? The doc strings above are used to generate the site documentation so it'd be good to advertise this feature if we're going to have it 😄 |
|
Oh, of course, I thought about doing it when I've found this out but then I totally forgot it |
|
Done! PS.: The |
keithamus
added a commit
that referenced
this pull request
Feb 1, 2016
Fix missing msg argument for change related assertions
|
💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was reading the code to solve #544 I found out the message parameter for change related methods (increases, decreases, etc...) on the assert interface wasn't being used at all.
I also took a look at chai's docs just to make sure it should be used.