Add .deep.property for deep equality comparisons
#758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, `expect(obj).not.property(name, val)` would throw an Error if `obj` didn't have a property named `name`. This change causes the assertion to pass instead. - assert.propertyNotVal renamed to assert.notPropertyVal - assert.deepPropertyNotVal renamed to assert.notDeepPropertyVal
- Previously, the `deep` flag had unexpected behavior when used with the `property` assertion: Instead of switching from strict to deep equality, it unlocked the ability to use dot and bracket notation when referencing property names. This behavior now belongs to the new `nested` flag. - assert.deepProperty renamed to assert.nestedProperty - assert.notDeepProperty renamed to assert.notNestedProperty - assert.deepPropertyVal renamed to assert.nestedPropertyVal - assert.notDeepPropertyVal renamed to assert.notNestedPropertyVal
This was referenced Jul 28, 2016
|
LGTM 👍. @lucasfcosta? |
|
LGTM 👍 too. Edit: Well, for some unknown reason, LGTM seems to be broken since it's not allowing me to merge this even though I have added a comment including the magical keyword. |
|
Let's see if this works: LGTM Edit: Looks like their website is down. |
|
Reposting because LGTM was down before. |
This was referenced Dec 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
.not.property(name, val)behavior #744 and Breaking: Rename.deep.propertyto.nested.property#757 are prerequisites for this PR. I recommend reviewing them first, and then only reviewing the newest commit in this PR..includeinternally leverages.propertywhen performing property assertions while providing a consistent, intuitive experience.deepflag inpropertyassertion #745