Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in the docstring of isNotExtensible #805

Closed
wants to merge 1 commit into from
Closed

Fix typo in the docstring of isNotExtensible #805

wants to merge 1 commit into from

Conversation

remarkablemark
Copy link

@remarkablemark remarkablemark commented Sep 26, 2016 •
edited
Loading

Fix Object.freeze misspelling.

See also chaijs/chaijs.github.io#140

@keithamus
Copy link
Member

Thanks @remarkablemark! LGTM

@meeber @lucasfcosta @vieiralucas ➡️

@remarkablemark remarkablemark mentioned this pull request Sep 26, 2016
Closed
@meeber
Copy link
Contributor

meeber commented Sep 26, 2016

@remarkablemark Thanks for the PR. This was actually fixed via #629, but the change doesn't make its way into the Chai.js file until it's regenerated as part of a new version release. We plan on releasing 4.0 soon at which point the change will appear.

@meeber meeber closed this Sep 26, 2016
@keithamus
Copy link
Member

Ahh, didn't notice that this was on the chai.js file. Good job we have a 2-review system!

@remarkablemark
Copy link
Author

Thanks @meeber for the clarification and thanks @keithamus for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remarkablemark @keithamus @meeber