-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Add support for GCP Secret Manager #124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for GCP Secret Manager #124
Conversation
gRPC Until then my suggestion to move forward would be to keep back gRPC and secret manager You can achieve that by running $ go get google.golang.org/grpc@v1.54.0
go: downloading cloud.google.com/go/secretmanager v1.10.0
go: downgraded cloud.google.com/go/secretmanager v1.10.1 => v1.10.0
go: downgraded google.golang.org/grpc v1.55.0 => v1.54.0 I've created this other issue to tackle the upgrade when possible #127 |
…tion Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev> Signed-off-by: gr0 <r.kuc@solr.pl>
70a8c1a
to
6366ab5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! Thanks a lot for the contribution!
Note that you might notice that I am being more strict with this code than with the foundation that you've worked on top of.
That's right, I am not super proud with some of the code I wrote, and I'd love to improve it. Via both contributions like yours and also by my own contributions, for which I expect you to be strict with me too! :)
Thanks for your patience and great work!
Let me know if you want to chat over discord or smth if it simplifies, speeds up the review process! :)
… there are issues with marshaling Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
…S README.md file Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
…regenerate the mock Signed-off-by: gr0 <r.kuc@solr.pl>
…the full credentials in configuration Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :), not approving modulo making sure the PK comment gets reviewed, see below.
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
…ey is redacted Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks a lot for the contribution! 🎉
Handles #108 and introduces the GCP Secret Manager to Chainloop. Allows the user to provide the project identifier and the key enabling access to the secret manager.
Any comments, suggestions, review is more than welcome :)