Skip to content

Conversation

gr0
Copy link
Collaborator

@gr0 gr0 commented May 22, 2023

Handles #108 and introduces the GCP Secret Manager to Chainloop. Allows the user to provide the project identifier and the key enabling access to the secret manager.

Any comments, suggestions, review is more than welcome :)

@migmartri migmartri requested review from danlishka and migmartri May 22, 2023 17:21
@migmartri migmartri changed the title Add support for GCP Secret Manager feat: Add support for GCP Secret Manager May 22, 2023
@migmartri
Copy link
Member

migmartri commented May 23, 2023

@gr0 please rebase main to include this check too #126

Thanks!

@migmartri
Copy link
Member

go mod tidy in this code will fails and this is the culprit #127

gRPC v1.55.0 is a dependency for the latest version of secretmanager which was added in this patch. The bad news is that kratos is not compatible with gRPC v1.55.0 yet go-kratos/kratos#2832 and the fix will be in the next release.

Until then my suggestion to move forward would be to keep back gRPC and secret manager

You can achieve that by running

$ go get google.golang.org/grpc@v1.54.0
go: downloading cloud.google.com/go/secretmanager v1.10.0
go: downgraded cloud.google.com/go/secretmanager v1.10.1 => v1.10.0
go: downgraded google.golang.org/grpc v1.55.0 => v1.54.0

I've created this other issue to tackle the upgrade when possible #127

gr0 and others added 6 commits May 23, 2023 13:33
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
Signed-off-by: gr0 <r.kuc@solr.pl>
@gr0 gr0 force-pushed the rafal/add-support-for-gcp-secret-manager branch from 70a8c1a to 6366ab5 Compare May 23, 2023 11:34
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks a lot for the contribution!

Note that you might notice that I am being more strict with this code than with the foundation that you've worked on top of.

That's right, I am not super proud with some of the code I wrote, and I'd love to improve it. Via both contributions like yours and also by my own contributions, for which I expect you to be strict with me too! :)

Thanks for your patience and great work!

Let me know if you want to chat over discord or smth if it simplifies, speeds up the review process! :)

gr0 added 7 commits May 25, 2023 14:03
… there are issues with marshaling

Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
…S README.md file

Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
…regenerate the mock

Signed-off-by: gr0 <r.kuc@solr.pl>
@gr0 gr0 marked this pull request as draft May 25, 2023 14:07
gr0 added 5 commits May 25, 2023 16:29
…the full credentials in configuration

Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
@gr0 gr0 requested a review from migmartri May 25, 2023 15:23
@gr0 gr0 marked this pull request as ready for review May 25, 2023 15:24
Signed-off-by: gr0 <r.kuc@solr.pl>
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :), not approving modulo making sure the PK comment gets reviewed, see below.

gr0 added 3 commits May 26, 2023 15:55
Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
gr0 added 2 commits May 26, 2023 16:36
…ey is redacted

Signed-off-by: gr0 <r.kuc@solr.pl>
Signed-off-by: gr0 <r.kuc@solr.pl>
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks a lot for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants