Skip to content

feat: handle inline backend upload/download #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat: handle inline backend upload/download #275

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions app/controlplane/internal/service/cascredential.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,19 @@ func (s *CASCredentialsService) Get(ctx context.Context, req *pb.CASCredentialsS
}

// Get repository to provide the secret name
repo, err := s.ociUC.FindDefaultBackend(ctx, currentOrg.ID)
backend, err := s.ociUC.FindDefaultBackend(ctx, currentOrg.ID)
if err != nil && !biz.IsNotFound(err) {
return nil, sl.LogAndMaskErr(err, s.log)
} else if repo == nil {
} else if backend == nil {
return nil, errors.NotFound("not found", "main repository not found")
}

t, err := s.casUC.GenerateTemporaryCredentials(repo.SecretName, role)
// If we want to upload an artifact but we have selected an inline backend we fail
if backend.Provider == biz.CASBackendInline {
return nil, errors.BadRequest("invalid argument", "cannot upload or download artifacts from an inline CAS backend")
}

t, err := s.casUC.GenerateTemporaryCredentials(backend.SecretName, role)
if err != nil {
return nil, sl.LogAndMaskErr(err, s.log)
}
Expand Down