Skip to content

feat: handle inline backend upload/download #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2023
Merged

feat: handle inline backend upload/download #275

merged 1 commit into from
Jul 27, 2023

Conversation

migmartri
Copy link
Member

this code makes chainloop artifact upload|download fail if the current cas backend is inline

  • Uploads are not possible in inline cas backends since in such case, uploads only make sense in the context of an attestation.
  • Downloads are not yet supported, they will eventually Handle inline artifacts downloads #248 but until then we handle it as an error.

Closes #265

@migmartri
feat: do not fail on cas backend
22a3bae 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested a review from danlishka July 27, 2023 14:52
@migmartri migmartri merged commit 0264f95 into chainloop-dev:main Jul 27, 2023
@migmartri migmartri deleted the prevent-upload branch July 27, 2023 21:45
@migmartri migmartri mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danlishka danlishka danlishka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Handle chainloop artifact command on inline backend

2 participants

@migmartri @danlishka