feat: Azure Devops Pipeline support #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmartri
approved these changes
Jul 27, 2023
| case *v1.CraftingSchema_Runner_GITLAB_PIPELINE.Enum(): | ||
| return "GitLab" | ||
| case *v1.CraftingSchema_Runner_AZURE_DEVOPS_PIPELINE.Enum(): | ||
| return "Azure DevOps Pipeline" |
There was a problem hiding this comment.
This information I believe will be shown in the tables, I am wondering if it's too long compared to the others.
In fact, here they seem to reference to it as Azure pipelines, would it make sense to do the same here?
There was a problem hiding this comment.
in fact, here they seem to reference to it as Azure pipelines
Yes, I found both references and was already thinking about making it shorter. Thanks, I will do it.
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
…ZURE_DEVOPS_PIPELINE Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has already been tested with local agent on Linux. I still want to spend more time validating it in the Azure cloud & k8s.
Documentation changes: chainloop-dev/docs#143
closes #273