feat(deployment): generate horizontal pod autoscaling proper version based on k8s version #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…based on k8s version Signed-off-by: Christophe de Carvalho <christophe@archipelo.co>
zaibon
force-pushed
the
upgrade_autoscaling
branch
from
1abd093 to
435b536
Compare
migmartri
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Great!
Something I usually do to simplify the life of the reviewer and speed up the review process is to include in the description of the PR the diff of the rendered version of the chart with the new change.
I generate it by executing something like
helm template foo deployment/chainloop -f ~/Desktop/values.local.yaml > /tmp/before.yaml
helm template foo deployment/chainloop -f ~/Desktop/values.local.yaml > /tmp/after.yaml && diff -u /tmp/before.yaml /tmp/after.yaml
|
Also note that you'll be not released this Helm Chart since you didn't bump the chart version. But I think it's ok because another release of the Chart is coming due to a bug I found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #321