Skip to content

feat(deployment): generate horizontal pod autoscaling proper version based on k8s version #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2023
Merged

feat(deployment): generate horizontal pod autoscaling proper version based on k8s version #322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions deployment/chainloop/templates/cas/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{{- if .Values.cas.autoscaling.enabled }}
apiVersion: autoscaling/v2beta1
apiVersion: {{ include "common.capabilities.hpa.apiVersion" ( dict "context" $ ) }}
kind: HorizontalPodAutoscaler
metadata:
name: {{ include "chainloop.cas.fullname" . }}
labels:
{{- include "chainloop.cas.labels" . | nindent 4 }}
spec:
scaleTargetRef:
apiVersion: apps/v1
apiVersion: {{ include "common.capabilities.deployment.apiVersion" . }}
kind: Deployment
name: {{ include "chainloop.cas.fullname" . }}
minReplicas: {{ .Values.cas.autoscaling.minReplicas }}
Expand All @@ -17,12 +17,24 @@ spec:
- type: Resource
resource:
name: cpu
{{- if semverCompare "<1.23-0" (include "common.capabilities.kubeVersion" .) }}
targetAverageUtilization: {{ .Values.cas.autoscaling.targetCPUUtilizationPercentage }}
{{- else }}
target:
type: Utilization
averageUtilization: {{ .Values.cas.autoscaling.targetCPUUtilizationPercentage }}
{{- end }}
{{- end }}
{{- if .Values.cas.autoscaling.targetMemoryUtilizationPercentage }}
- type: Resource
resource:
name: memory
{{- if semverCompare "<1.23-0" (include "common.capabilities.kubeVersion" .) }}
targetAverageUtilization: {{ .Values.cas.autoscaling.targetMemoryUtilizationPercentage }}
{{- else }}
target:
type: Utilization
averageUtilization: {{ .Values.cas.autoscaling.targetMemoryUtilizationPercentage }}
{{- end }}
{{- end }}
{{- end }}
14 changes: 13 additions & 1 deletion deployment/chainloop/templates/controlplane/hpa.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{- if .Values.controlplane.autoscaling.enabled }}
apiVersion: autoscaling/v2beta1
apiVersion: {{ include "common.capabilities.hpa.apiVersion" ( dict "context" $ ) }}
kind: HorizontalPodAutoscaler
metadata:
name: {{ include "chainloop.controlplane.fullname" . }}
Expand All @@ -17,12 +17,24 @@ spec:
- type: Resource
resource:
name: cpu
{{- if semverCompare "<1.23-0" (include "common.capabilities.kubeVersion" .) }}
targetAverageUtilization: {{ .Values.controlplane.autoscaling.targetCPUUtilizationPercentage }}
{{- else }}
target:
type: Utilization
averageUtilization: {{ .Values.controlplane.autoscaling.targetCPUUtilizationPercentage }}
{{- end }}
{{- end }}
{{- if .Values.controlplane.autoscaling.targetMemoryUtilizationPercentage }}
- type: Resource
resource:
name: memory
{{- if semverCompare "<1.23-0" (include "common.capabilities.kubeVersion" .) }}
targetAverageUtilization: {{ .Values.controlplane.autoscaling.targetMemoryUtilizationPercentage }}
{{- else }}
target:
type: Utilization
averageUtilization: {{ .Values.controlplane.autoscaling.targetMemoryUtilizationPercentage }}
{{- end }}
{{- end }}
{{- end }}